diff options
| author | Lai Jiangshan <laijs@cn.fujitsu.com> | 2009-01-08 03:07:36 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-08 17:31:02 +0100 |
| commit | 2019f634ce5904c19eba4e86f51b1a119a53a9f1 (patch) | |
| tree | 040b8645c0627baa0f4e44113589b5a4894ea629 /include/scsi/libsas.h | |
| parent | cgroups: add lock for child->cgroups in cgroup_post_fork() (diff) | |
| download | linux-2019f634ce5904c19eba4e86f51b1a119a53a9f1.tar.xz linux-2019f634ce5904c19eba4e86f51b1a119a53a9f1.zip | |
cgroups: fix cgroup_iter_next() bug
We access res->cgroups without the task_lock(), so res->cgroups may be
changed. it's unreliable, and "if (l == &res->cgroups->tasks)" may be
false forever.
We don't need add any lock for fixing this bug. we just access to struct
css_set by struct cg_cgroup_link, not by struct task_struct.
Since we hold css_set_lock, struct cg_cgroup_link is reliable.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Reviewed-by: Paul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Pavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/scsi/libsas.h')
0 files changed, 0 insertions, 0 deletions