diff options
author | Christoph Hellwig <hch@lst.de> | 2014-09-14 01:40:11 +0200 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2014-09-22 20:00:07 +0200 |
commit | 81481eb423c295c5480a3fab9bb961cf286c91e7 (patch) | |
tree | 3d4f0eaed9f784ba5beb41aa9fec3e76b867c1e8 /include/scsi | |
parent | blk-mq: rename blk_mq_end_io to blk_mq_end_request (diff) | |
download | linux-81481eb423c295c5480a3fab9bb961cf286c91e7.tar.xz linux-81481eb423c295c5480a3fab9bb961cf286c91e7.zip |
blk-mq: fix and simplify tag iteration for the timeout handler
Don't do a kmalloc from timer to handle timeouts, chances are we could be
under heavy load or similar and thus just miss out on the timeouts.
Fortunately it is very easy to just iterate over all in use tags, and doing
this properly actually cleans up the blk_mq_busy_iter API as well, and
prepares us for the next patch by passing a reserved argument to the
iterator.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'include/scsi')
-rw-r--r-- | include/scsi/scsi_tcq.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h index cdcc90b07ecb..e64583560701 100644 --- a/include/scsi/scsi_tcq.h +++ b/include/scsi/scsi_tcq.h @@ -68,7 +68,7 @@ static inline void scsi_activate_tcq(struct scsi_device *sdev, int depth) return; if (!shost_use_blk_mq(sdev->host) && - blk_queue_tagged(sdev->request_queue)) + !blk_queue_tagged(sdev->request_queue)) blk_queue_init_tags(sdev->request_queue, depth, sdev->host->bqt); |