summaryrefslogtreecommitdiffstats
path: root/include/sound/seq_midi_emul.h
diff options
context:
space:
mode:
authorWillem de Bruijn <willemb@google.com>2018-05-25 00:10:30 +0200
committerDavid S. Miller <davem@davemloft.net>2018-05-25 03:55:20 +0200
commit9aad13b087ab0a588cd68259de618f100053360e (patch)
tree3b8aa031c4bbfe2fe07021e9aa7de0805c63e926 /include/sound/seq_midi_emul.h
parentnet/mlx4: Fix irq-unsafe spinlock usage (diff)
downloadlinux-9aad13b087ab0a588cd68259de618f100053360e.tar.xz
linux-9aad13b087ab0a588cd68259de618f100053360e.zip
packet: fix reserve calculation
Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation") ensures that packet_snd always starts writing the link layer header in reserved headroom allocated for this purpose. This is needed because packets may be shorter than hard_header_len, in which case the space up to hard_header_len may be zeroed. But that necessary padding is not accounted for in skb->len. The fix, however, is buggy. It calls skb_push, which grows skb->len when moving skb->data back. But in this case packet length should not change. Instead, call skb_reserve, which moves both skb->data and skb->tail back, without changing length. Fixes: b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation") Reported-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: Willem de Bruijn <willemb@google.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/sound/seq_midi_emul.h')
0 files changed, 0 insertions, 0 deletions