diff options
| author | Takashi Iwai <tiwai@suse.de> | 2008-01-08 18:05:26 +0100 |
|---|---|---|
| committer | Jaroslav Kysela <perex@perex.cz> | 2008-01-31 17:29:47 +0100 |
| commit | d948035a928400ae127c873fbf771389bee18949 (patch) | |
| tree | 1f8c98f21627e0ae1747c471dfbc3148923d80dd /include/sound | |
| parent | [ALSA] Fix PCM write blocking (diff) | |
| download | linux-d948035a928400ae127c873fbf771389bee18949.tar.xz linux-d948035a928400ae127c873fbf771389bee18949.zip | |
[ALSA] Remove PCM xfer_align sw params
The xfer_align sw_params parameter has never been used in a sane manner,
and no one understands what this does exactly. The current
implementation looks also buggy because it allows write of shorter size
than xfer_align. So, if you do partial writes, the write isn't actually
aligned at all.
Removing this parameter will make some pcm_lib_* code more readable
(and less buggy).
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'include/sound')
| -rw-r--r-- | include/sound/asound.h | 2 | ||||
| -rw-r--r-- | include/sound/pcm.h | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/include/sound/asound.h b/include/sound/asound.h index ee753d782e2d..069d9120e622 100644 --- a/include/sound/asound.h +++ b/include/sound/asound.h @@ -363,7 +363,7 @@ struct snd_pcm_sw_params { unsigned int period_step; unsigned int sleep_min; /* min ticks to sleep */ snd_pcm_uframes_t avail_min; /* min avail frames for wakeup */ - snd_pcm_uframes_t xfer_align; /* xfer size need to be a multiple */ + snd_pcm_uframes_t xfer_align; /* obsolete: xfer size need to be a multiple */ snd_pcm_uframes_t start_threshold; /* min hw_avail frames for automatic start */ snd_pcm_uframes_t stop_threshold; /* min avail frames for automatic stop */ snd_pcm_uframes_t silence_threshold; /* min distance from noise for silence filling */ diff --git a/include/sound/pcm.h b/include/sound/pcm.h index 65f636223d39..1270cbce776a 100644 --- a/include/sound/pcm.h +++ b/include/sound/pcm.h @@ -287,7 +287,6 @@ struct snd_pcm_runtime { int tstamp_mode; /* mmap timestamp is updated */ unsigned int period_step; unsigned int sleep_min; /* min ticks to sleep */ - snd_pcm_uframes_t xfer_align; /* xfer size need to be a multiple */ snd_pcm_uframes_t start_threshold; snd_pcm_uframes_t stop_threshold; snd_pcm_uframes_t silence_threshold; /* Silence filling happens when |