diff options
| author | Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com> | 2022-06-24 23:34:25 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-06-27 12:57:06 +0200 |
| commit | 6deb209dc6b0952a460da17ee61223ee3b3429d5 (patch) | |
| tree | 52b2aae2c218abf0033f613a233fc9313d543d5d /include/trace/events/net.h | |
| parent | Merge tag 'linux-can-next-for-5.20-20220625' of git://git.kernel.org/pub/scm/... (diff) | |
| download | linux-6deb209dc6b0952a460da17ee61223ee3b3429d5.tar.xz linux-6deb209dc6b0952a460da17ee61223ee3b3429d5.zip | |
net: Print hashed skb addresses for all net and qdisc events
The following commits added support for printing the real address-
65875073eddd ("net: use %px to print skb address in trace_netif_receive_skb")
70713dddf3d2 ("net_sched: introduce tracepoint trace_qdisc_enqueue()")
851f36e40962 ("net_sched: use %px to print skb address in trace_qdisc_dequeue()")
However, tracing the packet traversal shows a mix of hashes and real
addresses. Pasting a sample trace for reference-
ping-14249 [002] ..... 3424.046612: netif_rx_entry: dev=lo napi_id=0x3 queue_mapping=0
skbaddr=00000000dcbed83e vlan_tagged=0 vlan_proto=0x0000 vlan_tci=0x0000 protocol=0x0800
ip_summed=0 hash=0x00000000 l4_hash=0 len=84 data_len=0 truesize=768 mac_header_valid=1
mac_header=-14 nr_frags=0 gso_size=0 gso_type=0x0
ping-14249 [002] ..... 3424.046615: netif_rx: dev=lo skbaddr=ffffff888e5d1000 len=84
Switch the trace print formats to %p for all the events to have a
consistent format of printing the hashed addresses in all cases.
Signed-off-by: Sean Tranchetti <quic_stranche@quicinc.com>
Signed-off-by: Subash Abhinov Kasiviswanathan <quic_subashab@quicinc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/trace/events/net.h')
| -rw-r--r-- | include/trace/events/net.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/trace/events/net.h b/include/trace/events/net.h index 032b431b987b..da611a7aaf97 100644 --- a/include/trace/events/net.h +++ b/include/trace/events/net.h @@ -136,7 +136,7 @@ DECLARE_EVENT_CLASS(net_dev_template, __assign_str(name, skb->dev->name); ), - TP_printk("dev=%s skbaddr=%px len=%u", + TP_printk("dev=%s skbaddr=%p len=%u", __get_str(name), __entry->skbaddr, __entry->len) ) |