diff options
| author | Florian Westphal <fw@strlen.de> | 2021-06-08 23:06:07 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2021-06-09 21:29:23 +0200 |
| commit | c5c6accd7b7e10434d6afda4f6a5107c480bb4fb (patch) | |
| tree | 3634d26b4cd6d240a59c63784d194c0166f05dff /include/uapi | |
| parent | netfilter: nfnetlink_hook: add depends-on nftables (diff) | |
| download | linux-c5c6accd7b7e10434d6afda4f6a5107c480bb4fb.tar.xz linux-c5c6accd7b7e10434d6afda4f6a5107c480bb4fb.zip | |
netfilter: nf_tables: move base hook annotation to init helper
coverity scanner says:
2187 if (nft_is_base_chain(chain)) {
vvv CID 1505166: Memory - corruptions (UNINIT)
vvv Using uninitialized value "basechain".
2188 basechain->ops.hook_ops_type = NF_HOOK_OP_NF_TABLES;
... I don't see how nft_is_base_chain() can evaluate to true
while basechain pointer is garbage.
However, it seems better to place the NF_HOOK_OP_NF_TABLES annotation
in nft_basechain_hook_init() instead.
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1505166 ("Memory - corruptions")
Fixes: 65b8b7bfc5284f ("netfilter: annotate nf_tables base hook ops")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'include/uapi')
0 files changed, 0 insertions, 0 deletions