diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-03-25 02:11:57 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-26 00:46:53 +0100 |
| commit | 240e114411e74d2ee8121643e0c67717eb7c6982 (patch) | |
| tree | b147d614c9081f170e9b8b357e82750dd997dc3a /include/uapi | |
| parent | ethtool: fec: remove long structure description (diff) | |
| download | linux-240e114411e74d2ee8121643e0c67717eb7c6982.tar.xz linux-240e114411e74d2ee8121643e0c67717eb7c6982.zip | |
ethtool: fec: sanitize ethtool_fecparam->reserved
struct ethtool_fecparam::reserved is never looked at by the core.
Make sure it's actually 0. Unfortunately we can't return an error
because old ethtool doesn't zero-initialize the structure for SET.
On GET we can be more verbose, there are no in tree (ab)users.
Fix up the kdoc on the structure. Remove the mention of FEC
bypass. Seems like a niche thing to configure in the first
place.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi')
| -rw-r--r-- | include/uapi/linux/ethtool.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 36bf435d232c..9e2682a67460 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -1380,7 +1380,7 @@ struct ethtool_per_queue_op { * @cmd: Command number = %ETHTOOL_GFECPARAM or %ETHTOOL_SFECPARAM * @active_fec: FEC mode which is active on the port * @fec: Bitmask of supported/configured FEC modes - * @rsvd: Reserved for future extensions. i.e FEC bypass feature. + * @reserved: Reserved for future extensions, ignore on GET, write 0 for SET. */ struct ethtool_fecparam { __u32 cmd; |