diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2009-07-27 04:11:14 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-27 04:11:14 +0200 |
| commit | dcf777f6ed9799c5ac90ac17a5c369e6b73ca92e (patch) | |
| tree | dc15b2d5800241d124528d627f8b039ac29d32d4 /include | |
| parent | eepro: Read buffer overflow (diff) | |
| download | linux-dcf777f6ed9799c5ac90ac17a5c369e6b73ca92e.tar.xz linux-dcf777f6ed9799c5ac90ac17a5c369e6b73ca92e.zip | |
NET: ROSE: Don't use static buffer.
The use of a static buffer in rose2asc() to return its result is not
threadproof and can result in corruption if multiple threads are trying
to use one of the procfs files based on rose2asc().
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/rose.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/rose.h b/include/net/rose.h index cbd5364b2c8a..5ba9f02731eb 100644 --- a/include/net/rose.h +++ b/include/net/rose.h @@ -156,7 +156,7 @@ extern int sysctl_rose_maximum_vcs; extern int sysctl_rose_window_size; extern int rosecmp(rose_address *, rose_address *); extern int rosecmpm(rose_address *, rose_address *, unsigned short); -extern const char *rose2asc(const rose_address *); +extern char *rose2asc(char *buf, const rose_address *); extern struct sock *rose_find_socket(unsigned int, struct rose_neigh *); extern void rose_kill_by_neigh(struct rose_neigh *); extern unsigned int rose_new_lci(struct rose_neigh *); |