diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2013-02-09 22:29:20 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2013-02-09 22:29:20 +0100 |
| commit | b6e96d0067d81f6a300bedee661b5ece8164e210 (patch) | |
| tree | 0c44eb0c27044a235cdf279016afc1e2d7800e7b /include | |
| parent | ext4: use module parameters instead of debugfs for mballoc_debug (diff) | |
| download | linux-b6e96d0067d81f6a300bedee661b5ece8164e210.tar.xz linux-b6e96d0067d81f6a300bedee661b5ece8164e210.zip | |
jbd2: use module parameters instead of debugfs for jbd_debug
There are multiple reasons to move away from debugfs. First of all,
we are only using it for a single parameter, and it is much more
complicated to set up (some 30 lines of code compared to 3), and one
more thing that might fail while loading the jbd2 module.
Secondly, as a module paramter it can be specified as a boot option if
jbd2 is built into the kernel, or as a parameter when the module is
loaded, and it can also be manipulated dynamically under
/sys/module/jbd2/parameters/jbd2_debug. So it is more flexible.
Ultimately we want to move away from using jbd_debug() towards
tracepoints, but for now this is still a useful simplification of the
code base.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/jbd2.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index fa5fea17b619..50e5a5e6a712 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -20,7 +20,6 @@ #ifndef __KERNEL__ #include "jfs_compat.h" #define JBD2_DEBUG -#define jfs_debug jbd_debug #else #include <linux/types.h> @@ -57,7 +56,7 @@ * CONFIG_JBD2_DEBUG is on. */ #define JBD2_EXPENSIVE_CHECKING -extern u8 jbd2_journal_enable_debug; +extern ushort jbd2_journal_enable_debug; #define jbd_debug(n, f, a...) \ do { \ |