diff options
| author | Mathias Krause <minipli@googlemail.com> | 2014-07-12 22:36:44 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-07-14 23:32:51 +0200 |
| commit | 9ecf07a1d8f70f72ec99a0f102c8aa24609d84f4 (patch) | |
| tree | b1fc7364af39c287a118bd990ae2422db2a43d27 /include | |
| parent | net: sctp: fix information leaks in ulpevent layer (diff) | |
| download | linux-9ecf07a1d8f70f72ec99a0f102c8aa24609d84f4.tar.xz linux-9ecf07a1d8f70f72ec99a0f102c8aa24609d84f4.zip | |
neigh: sysctl - simplify address calculation of gc_* variables
The code in neigh_sysctl_register() relies on a specific layout of
struct neigh_table, namely that the 'gc_*' variables are directly
following the 'parms' member in a specific order. The code, though,
expresses this in the most ugly way.
Get rid of the ugly casts and use the 'tbl' pointer to get a handle to
the table. This way we can refer to the 'gc_*' variables directly.
Similarly seen in the grsecurity patch, written by Brad Spengler.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Brad Spengler <spender@grsecurity.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/neighbour.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/net/neighbour.h b/include/net/neighbour.h index 7277caf3743d..47f425464f84 100644 --- a/include/net/neighbour.h +++ b/include/net/neighbour.h @@ -203,7 +203,6 @@ struct neigh_table { void (*proxy_redo)(struct sk_buff *skb); char *id; struct neigh_parms parms; - /* HACK. gc_* should follow parms without a gap! */ int gc_interval; int gc_thresh1; int gc_thresh2; |