diff options
author | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2018-01-04 19:06:49 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-01-05 19:59:18 +0100 |
commit | 5133550296d43236439494aa955bfb765a89f615 (patch) | |
tree | 063dae710a03b45c1c7a119f7dfa8c10360c1729 /include | |
parent | Merge tag 'linux-can-fixes-for-4.15-20180104' of git://git.kernel.org/pub/scm... (diff) | |
download | linux-5133550296d43236439494aa955bfb765a89f615.tar.xz linux-5133550296d43236439494aa955bfb765a89f615.zip |
sh_eth: fix SH7757 GEther initialization
Renesas SH7757 has 2 Fast and 2 Gigabit Ether controllers, while the
'sh_eth' driver can only reset and initialize TSU of the first controller
pair. Shimoda-san tried to solve that adding the 'needs_init' member to the
'struct sh_eth_plat_data', however the platform code still never sets this
flag. I think that we can infer this information from the 'devno' variable
(set to 'platform_device::id') and reset/init the Ether controller pair
only for an even 'devno'; therefore 'sh_eth_plat_data::needs_init' can be
removed...
Fixes: 150647fb2c31 ("net: sh_eth: change the condition of initialization")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/sh_eth.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/sh_eth.h b/include/linux/sh_eth.h index ff3642d267f7..94081e9a5010 100644 --- a/include/linux/sh_eth.h +++ b/include/linux/sh_eth.h @@ -17,7 +17,6 @@ struct sh_eth_plat_data { unsigned char mac_addr[ETH_ALEN]; unsigned no_ether_link:1; unsigned ether_link_active_low:1; - unsigned needs_init:1; }; #endif |