summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorJiri Pirko <jiri@resnulli.us>2013-06-08 15:00:55 +0200
committerDavid S. Miller <davem@davemloft.net>2013-06-12 09:56:27 +0200
commitb79462a8b9f9a452edc20c64a70a89ba3b0a6a88 (patch)
tree1fee0cd72cc92c6d0b3892c9b99af7a8e4382405 /include
parentteam: move add to port list before port enablement (diff)
downloadlinux-b79462a8b9f9a452edc20c64a70a89ba3b0a6a88.tar.xz
linux-b79462a8b9f9a452edc20c64a70a89ba3b0a6a88.zip
team: fix checks in team_get_first_port_txable_rcu()
should be checked if "cur" is txable, not "port". Introduced by commit 6e88e1357c "team: use function team_port_txable() for determing enabled and up port" Signed-off-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r--include/linux/if_team.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/if_team.h b/include/linux/if_team.h
index 4474557904f6..16fae6436d0e 100644
--- a/include/linux/if_team.h
+++ b/include/linux/if_team.h
@@ -249,12 +249,12 @@ team_get_first_port_txable_rcu(struct team *team, struct team_port *port)
return port;
cur = port;
list_for_each_entry_continue_rcu(cur, &team->port_list, list)
- if (team_port_txable(port))
+ if (team_port_txable(cur))
return cur;
list_for_each_entry_rcu(cur, &team->port_list, list) {
if (cur == port)
break;
- if (team_port_txable(port))
+ if (team_port_txable(cur))
return cur;
}
return NULL;