diff options
| author | Xin Long <lucien.xin@gmail.com> | 2019-03-18 12:47:00 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-03-19 02:16:12 +0100 |
| commit | 273160ffc6b993c7c91627f5a84799c66dfe4dee (patch) | |
| tree | 8429227bffe3b709ddce84b0e841a8ccb851f6b9 /include | |
| parent | af_packet: fix the tx skb protocol in raw sockets with ETH_P_ALL (diff) | |
| download | linux-273160ffc6b993c7c91627f5a84799c66dfe4dee.tar.xz linux-273160ffc6b993c7c91627f5a84799c66dfe4dee.zip | |
sctp: get sctphdr by offset in sctp_compute_cksum
sctp_hdr(skb) only works when skb->transport_header is set properly.
But in Netfilter, skb->transport_header for ipv6 is not guaranteed
to be right value for sctphdr. It would cause to fail to check the
checksum for sctp packets.
So fix it by using offset, which is always right in all places.
v1->v2:
- Fix the changelog.
Fixes: e6d8b64b34aa ("net: sctp: fix and consolidate SCTP checksumming code")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/sctp/checksum.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/sctp/checksum.h b/include/net/sctp/checksum.h index 32ee65a30aff..1c6e6c0766ca 100644 --- a/include/net/sctp/checksum.h +++ b/include/net/sctp/checksum.h @@ -61,7 +61,7 @@ static inline __wsum sctp_csum_combine(__wsum csum, __wsum csum2, static inline __le32 sctp_compute_cksum(const struct sk_buff *skb, unsigned int offset) { - struct sctphdr *sh = sctp_hdr(skb); + struct sctphdr *sh = (struct sctphdr *)(skb->data + offset); const struct skb_checksum_ops ops = { .update = sctp_csum_update, .combine = sctp_csum_combine, |