diff options
| author | Xie He <xie.he.0141@gmail.com> | 2020-12-28 03:53:39 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-12-29 00:09:04 +0100 |
| commit | 1fef73597fa545c35fddc953979013882fbd4e55 (patch) | |
| tree | 53dafb4464b51d40281343097c9698180d0eface /include | |
| parent | atlantic: remove architecture depends (diff) | |
| download | linux-1fef73597fa545c35fddc953979013882fbd4e55.tar.xz linux-1fef73597fa545c35fddc953979013882fbd4e55.zip | |
net: hdlc_ppp: Fix issues when mod_timer is called while timer is running
ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock"
held. It may call mod_timer to add a new timer. However, at the same time
ppp_timer may be already running and waiting for "ppp->lock". In this
case, there's no need for ppp_timer to continue running and it can just
exit.
If we let ppp_timer continue running, it may call add_timer. This causes
kernel panic because add_timer can't be called with a timer pending.
This patch fixes this problem.
Fixes: e022c2f07ae5 ("WAN: new synchronous PPP implementation for generic HDLC.")
Cc: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions