diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-13 22:51:53 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-15 12:49:55 +0200 |
| commit | 60c158dc7b1f0558f6cadd5b50d0386da0000d50 (patch) | |
| tree | 7f70607a57abd8881ac567ffdeb7f67c0960d47e /include | |
| parent | ip: Fix data-races around sysctl_ip_no_pmtu_disc. (diff) | |
| download | linux-60c158dc7b1f0558f6cadd5b50d0386da0000d50.tar.xz linux-60c158dc7b1f0558f6cadd5b50d0386da0000d50.zip | |
ip: Fix data-races around sysctl_ip_fwd_use_pmtu.
While reading sysctl_ip_fwd_use_pmtu, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: f87c10a8aa1e ("ipv4: introduce ip_dst_mtu_maybe_forward and protect forwarding path against pmtu spoofing")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/ip.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/ip.h b/include/net/ip.h index 26fffda78cca..05fe313f72fa 100644 --- a/include/net/ip.h +++ b/include/net/ip.h @@ -446,7 +446,7 @@ static inline unsigned int ip_dst_mtu_maybe_forward(const struct dst_entry *dst, struct net *net = dev_net(dst->dev); unsigned int mtu; - if (net->ipv4.sysctl_ip_fwd_use_pmtu || + if (READ_ONCE(net->ipv4.sysctl_ip_fwd_use_pmtu) || ip_mtu_locked(dst) || !forwarding) { mtu = rt->rt_pmtu; |