diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-31 15:17:15 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-08-01 14:55:40 +0200 |
| commit | fee531d6fc49b9a616525e30955c4cf3b403f632 (patch) | |
| tree | 1f612f6396e02d172e7b65674aa2a6fcc6e38262 /include | |
| parent | ASoC: Intel: SoC: skylake: no need to check return value of debugfs_create fu... (diff) | |
| download | linux-fee531d6fc49b9a616525e30955c4cf3b403f632.tar.xz linux-fee531d6fc49b9a616525e30955c4cf3b403f632.zip | |
ASoC: core: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Also, there is no need to store the individual debugfs file name, just
remove the whole directory all at once, saving a local variable.
Note, the soc-pcm "state" file has now moved to a subdirectory, as it is
only a good idea to save the dentries for debugfs directories, not
individual files, as the individual file debugfs functions are changing
to not return a dentry.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20190731131716.9764-2-gregkh@linuxfoundation.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/sound/soc.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/sound/soc.h b/include/sound/soc.h index d770606732cd..f0797792dd8d 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -1220,7 +1220,6 @@ struct snd_soc_card { #ifdef CONFIG_DEBUG_FS struct dentry *debugfs_card_root; - struct dentry *debugfs_pop_time; #endif u32 pop_time; |