diff options
author | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-04-06 15:55:25 +0200 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2016-04-20 18:16:14 +0200 |
commit | 5ed470feb9a121582dbd455c72b133dc1a856a0a (patch) | |
tree | 2229f72ba54bc3950f5b7c94e3150f66fee48ee7 /include | |
parent | [media] media-device: get rid of the spinlock (diff) | |
download | linux-5ed470feb9a121582dbd455c72b133dc1a856a0a.tar.xz linux-5ed470feb9a121582dbd455c72b133dc1a856a0a.zip |
[media] media: Improve documentation for link_setup/link_modify
Those callbacks are called with the media_device.graph_mutex held.
Add a note about that, as the code called by those notifiers should
not be touching in the mutex.
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/media/media-device.h | 3 | ||||
-rw-r--r-- | include/media/media-entity.h | 3 |
2 files changed, 5 insertions, 1 deletions
diff --git a/include/media/media-device.h b/include/media/media-device.h index b21ef244ad3e..a9b33c47310d 100644 --- a/include/media/media-device.h +++ b/include/media/media-device.h @@ -311,7 +311,8 @@ struct media_entity_notify { * @enable_source: Enable Source Handler function pointer * @disable_source: Disable Source Handler function pointer * - * @link_notify: Link state change notification callback + * @link_notify: Link state change notification callback. This callback is + * called with the graph_mutex held. * * This structure represents an abstract high-level media device. It allows easy * access to entities and provides basic media device-level support. The diff --git a/include/media/media-entity.h b/include/media/media-entity.h index e0295eefd702..cbb266f7f2b5 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -179,6 +179,9 @@ struct media_pad { * @link_validate: Return whether a link is valid from the entity point of * view. The media_entity_pipeline_start() function * validates all links by calling this operation. Optional. + * + * Note: Those these callbacks are called with struct media_device.@graph_mutex + * mutex held. */ struct media_entity_operations { int (*link_setup)(struct media_entity *entity, |