diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-09-18 16:27:56 +0200 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2020-09-18 23:34:52 +0200 |
| commit | c011410d9145695c460567fa5ba1ade6a7b16f06 (patch) | |
| tree | bd375d517b90c44e6d43f5430be3f9f601011f80 /include | |
| parent | ipmi: add retry in try_get_dev_id() (diff) | |
| download | linux-c011410d9145695c460567fa5ba1ade6a7b16f06.tar.xz linux-c011410d9145695c460567fa5ba1ade6a7b16f06.zip | |
ipmi: msghandler: Fix a signedness bug
The type for the completion codes should be unsigned char instead of
char. If it is declared as a normal char then the conditions in
__get_device_id() are impossible because the IPMI_DEVICE_IN_FW_UPDATE_ERR
error codes are higher than 127.
drivers/char/ipmi/ipmi_msghandler.c:2449 __get_device_id()
warn: impossible condition '(bmc->cc == 209) => ((-128)-127 == 209)'
Fixes: f8910ffa81b0 ("ipmi:msghandler: retry to get device id on an error")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Message-Id: <20200918142756.GB909725@mwanda>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions