diff options
author | Peter Xu <peterx@redhat.com> | 2024-04-17 23:18:35 +0200 |
---|---|---|
committer | Andrew Morton <akpm@linux-foundation.org> | 2024-04-25 04:34:25 +0200 |
commit | b76b46902c2d0395488c8412e1116c2486cdfcb2 (patch) | |
tree | 2cac9e74a99592a3f3cea9edbf891d88bcd31331 /init/init_task.c | |
parent | selftests: mm: fix unused and uninitialized variable warning (diff) | |
download | linux-b76b46902c2d0395488c8412e1116c2486cdfcb2.tar.xz linux-b76b46902c2d0395488c8412e1116c2486cdfcb2.zip |
mm/hugetlb: fix missing hugetlb_lock for resv uncharge
There is a recent report on UFFDIO_COPY over hugetlb:
https://lore.kernel.org/all/000000000000ee06de0616177560@google.com/
350: lockdep_assert_held(&hugetlb_lock);
Should be an issue in hugetlb but triggered in an userfault context, where
it goes into the unlikely path where two threads modifying the resv map
together. Mike has a fix in that path for resv uncharge but it looks like
the locking criteria was overlooked: hugetlb_cgroup_uncharge_folio_rsvd()
will update the cgroup pointer, so it requires to be called with the lock
held.
Link: https://lkml.kernel.org/r/20240417211836.2742593-3-peterx@redhat.com
Fixes: 79aa925bf239 ("hugetlb_cgroup: fix reservation accounting")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reported-by: syzbot+4b8077a5fccc61c385a1@syzkaller.appspotmail.com
Reviewed-by: Mina Almasry <almasrymina@google.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'init/init_task.c')
0 files changed, 0 insertions, 0 deletions