summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2016-11-09 09:55:04 +0100
committerMichael Ellerman <mpe@ellerman.id.au>2016-11-14 10:06:00 +0100
commit0e27d27e0d6d92342797e0d37738c276c1ff090e (patch)
tree462e004ad4fc6967b4d3514e6711c8d6f49387a0 /init
parentpowerpc/pci/rpadlpar: Fix device reference leaks (diff)
downloadlinux-0e27d27e0d6d92342797e0d37738c276c1ff090e.tar.xz
linux-0e27d27e0d6d92342797e0d37738c276c1ff090e.zip
selftests/powerpc: Return false instead of -1 in require_paranoia_below()
Returning a negative value for a boolean function seem to have the undesired effect of returning true. require_paranoia_below() is a boolean function, but the variable used to store the return value is an integer, receiving -1 or 0. This patch converts rc to bool, replaces -1 by false, and 0 by true. mpe: This wasn't exhibiting in practice because the common case, where we do the comparison of the desired level vs the current value, was being compiled into a computation based on the result of the comparison, ie. it wasn't using the default -1 value at all. However that was just luck and the code is still wrong. Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions