summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorAndrew Morton <akpm@osdl.org>2006-03-25 12:07:48 +0100
committerLinus Torvalds <torvalds@g5.osdl.org>2006-03-25 17:22:57 +0100
commit05eeae208d08a05a6980cf2ff61f02843c0955fd (patch)
treebe6c6c4e16cfac07edf437a1f74ef027ada8ccc7 /init
parent[PATCH] ext3: Fix debug logging-only compilation error (diff)
downloadlinux-05eeae208d08a05a6980cf2ff61f02843c0955fd.tar.xz
linux-05eeae208d08a05a6980cf2ff61f02843c0955fd.zip
[PATCH] find_task_by_pid() needs tasklist_lock
A couple of places are forgetting to take it. The kswapd case is probably unimportant. keventd_create_kthread() was racy. The whole thing is a bit flakey: you start a kernel thread, get its pid from kernel_thread() then look up its task_struct. a) It assumes that pid recycling takes a "long" time. b) We get a task_struct but no reference was taken on it. The owner of the kswapd and kthread task_struct*'s must assume that the new thread won't exit unexpectedly. Because if it does, they're left holding dead memory and any attempt to control or stop that task will crash. Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions