diff options
author | Steve Grubb <sgrubb@redhat.com> | 2016-11-16 22:14:33 +0100 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2016-11-20 21:38:00 +0100 |
commit | c1e8f06d7a0eea232ce0767471e1b4756ccab70a (patch) | |
tree | 5b33f318b333b8bf61e2f24f9767bc977b2c261e /kernel/audit_fsnotify.c | |
parent | audit: skip sessionid sentinel value when auto-incrementing (diff) | |
download | linux-c1e8f06d7a0eea232ce0767471e1b4756ccab70a.tar.xz linux-c1e8f06d7a0eea232ce0767471e1b4756ccab70a.zip |
audit: fix formatting of AUDIT_CONFIG_CHANGE events
The AUDIT_CONFIG_CHANGE events sometimes use a op= field. The current
code logs the value of the field with quotes. This field is documented
to not be encoded, so it should not have quotes.
Signed-off-by: Steve Grubb <sgrubb@redhat.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
[PM: reformatted commit description to make checkpatch.pl happy]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'kernel/audit_fsnotify.c')
-rw-r--r-- | kernel/audit_fsnotify.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c index f84f8d06e1f6..f75154889aa9 100644 --- a/kernel/audit_fsnotify.c +++ b/kernel/audit_fsnotify.c @@ -130,10 +130,9 @@ static void audit_mark_log_rule_change(struct audit_fsnotify_mark *audit_mark, c ab = audit_log_start(NULL, GFP_NOFS, AUDIT_CONFIG_CHANGE); if (unlikely(!ab)) return; - audit_log_format(ab, "auid=%u ses=%u op=", + audit_log_format(ab, "auid=%u ses=%u op=%s", from_kuid(&init_user_ns, audit_get_loginuid(current)), - audit_get_sessionid(current)); - audit_log_string(ab, op); + audit_get_sessionid(current), op); audit_log_format(ab, " path="); audit_log_untrustedstring(ab, audit_mark->path); audit_log_key(ab, rule->filterkey); |