diff options
| author | Jeongjun Park <aha310510@gmail.com> | 2024-08-31 07:47:02 +0200 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2024-09-04 20:56:34 +0200 |
| commit | bb6705c3f93bed2af03d43691743d4c43e3c8e6f (patch) | |
| tree | 930dce457cb48dc146e4fadd65db839cdb2487d4 /kernel/bpf/btf.c | |
| parent | bpf: Fix a crash when btf_parse_base() returns an error pointer (diff) | |
| download | linux-bb6705c3f93bed2af03d43691743d4c43e3c8e6f.tar.xz linux-bb6705c3f93bed2af03d43691743d4c43e3c8e6f.zip | |
bpf: add check for invalid name in btf_name_valid_section()
If the length of the name string is 1 and the value of name[0] is NULL
byte, an OOB vulnerability occurs in btf_name_valid_section() and the
return value is true, so the invalid name passes the check.
To solve this, you need to check if the first position is NULL byte and
if the first character is printable.
Suggested-by: Eduard Zingerman <eddyz87@gmail.com>
Fixes: bd70a8fb7ca4 ("bpf: Allow all printable characters in BTF DATASEC names")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
Link: https://lore.kernel.org/r/20240831054702.364455-1-aha310510@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | kernel/bpf/btf.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index e3377dd61f7e..a4e4f8d43ecf 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -823,9 +823,11 @@ static bool btf_name_valid_section(const struct btf *btf, u32 offset) const char *src = btf_str_by_offset(btf, offset); const char *src_limit; + if (!*src) + return false; + /* set a limit on identifier length */ src_limit = src + KSYM_NAME_LEN; - src++; while (*src && src < src_limit) { if (!isprint(*src)) return false; |