diff options
| author | Roman Gushchin <guro@fb.com> | 2018-09-28 15:33:21 +0200 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2018-09-28 15:50:23 +0200 |
| commit | 4288ea006c73e37c2a4f60dfaef20dd167b8df31 (patch) | |
| tree | 6e43c3f3344f8f54baed168fb23f16bffcf4c7aa /kernel/bpf/local_storage.c | |
| parent | net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int (diff) | |
| download | linux-4288ea006c73e37c2a4f60dfaef20dd167b8df31.tar.xz linux-4288ea006c73e37c2a4f60dfaef20dd167b8df31.zip | |
bpf: harden flags check in cgroup_storage_update_elem()
cgroup_storage_update_elem() shouldn't accept any flags
argument values except BPF_ANY and BPF_EXIST to guarantee
the backward compatibility, had a new flag value been added.
Fixes: de9cbbaadba5 ("bpf: introduce cgroup storage maps")
Signed-off-by: Roman Gushchin <guro@fb.com>
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'kernel/bpf/local_storage.c')
| -rw-r--r-- | kernel/bpf/local_storage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c index 22ad967d1e5f..94126cbffc88 100644 --- a/kernel/bpf/local_storage.c +++ b/kernel/bpf/local_storage.c @@ -129,7 +129,7 @@ static int cgroup_storage_update_elem(struct bpf_map *map, void *_key, struct bpf_cgroup_storage *storage; struct bpf_storage_buffer *new; - if (flags & BPF_NOEXIST) + if (flags != BPF_ANY && flags != BPF_EXIST) return -EINVAL; storage = cgroup_storage_lookup((struct bpf_cgroup_storage_map *)map, |