summaryrefslogtreecommitdiffstats
path: root/kernel/bpf
diff options
context:
space:
mode:
authorJakub Sitnicki <jakub@cloudflare.com>2020-05-25 14:29:28 +0200
committerAlexei Starovoitov <ast@kernel.org>2020-06-01 23:38:19 +0200
commitfe537393b5795ecbe5746eec0e16124bc998a594 (patch)
treeec320e5e1cf106fb6ac8897740bc0988817bf11d /kernel/bpf
parenttools, bpftool: Print correct error message when failing to load BTF (diff)
downloadlinux-fe537393b5795ecbe5746eec0e16124bc998a594.tar.xz
linux-fe537393b5795ecbe5746eec0e16124bc998a594.zip
bpf: Fix returned error sign when link doesn't support updates
System calls encode returned errors as negative values. Fix a typo that breaks this convention for bpf(LINK_UPDATE) when bpf_link doesn't support update operation. Fixes: f9d041271cf4 ("bpf: Refactor bpf_link update handling") Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20200525122928.1164495-1-jakub@cloudflare.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/bpf')
-rw-r--r--kernel/bpf/syscall.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index aaa29fb6f363..d13b804ff045 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -3924,7 +3924,7 @@ static int link_update(union bpf_attr *attr)
if (link->ops->update_prog)
ret = link->ops->update_prog(link, new_prog, old_prog);
else
- ret = EINVAL;
+ ret = -EINVAL;
out_put_progs:
if (old_prog)