diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2019-11-03 19:55:43 +0100 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2019-11-10 17:57:45 +0100 |
commit | 762c69685ff7ad5ad7fee0656671e20a0c9c864d (patch) | |
tree | 9dd2bdbab0f29a6ed9014f56db9ec384c327a282 /kernel/cgroup | |
parent | ecryptfs_lookup_interpose(): lower_dentry->d_inode is not stable (diff) | |
download | linux-762c69685ff7ad5ad7fee0656671e20a0c9c864d.tar.xz linux-762c69685ff7ad5ad7fee0656671e20a0c9c864d.zip |
ecryptfs_lookup_interpose(): lower_dentry->d_parent is not stable either
We need to get the underlying dentry of parent; sure, absent the races
it is the parent of underlying dentry, but there's nothing to prevent
losing a timeslice to preemtion in the middle of evaluation of
lower_dentry->d_parent->d_inode, having another process move lower_dentry
around and have its (ex)parent not pinned anymore and freed on memory
pressure. Then we regain CPU and try to fetch ->d_inode from memory
that is freed by that point.
dentry->d_parent *is* stable here - it's an argument of ->lookup() and
we are guaranteed that it won't be moved anywhere until we feed it
to d_add/d_splice_alias. So we safely go that way to get to its
underlying dentry.
Cc: stable@vger.kernel.org # since 2009 or so
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel/cgroup')
0 files changed, 0 insertions, 0 deletions