diff options
| author | Tejun Heo <tj@kernel.org> | 2019-06-10 18:08:27 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2019-06-10 18:08:27 +0200 |
| commit | c596687a008b579c503afb7a64fcacc7270fae9e (patch) | |
| tree | 967bd09e70fafd8109e61004ac9e9fe217df1b8b /kernel/cgroup | |
| parent | cgroup: css_task_iter_skip()'d iterators must be advanced before accessed (diff) | |
| download | linux-c596687a008b579c503afb7a64fcacc7270fae9e.tar.xz linux-c596687a008b579c503afb7a64fcacc7270fae9e.zip | |
cgroup: Fix css_task_iter_advance_css_set() cset skip condition
While adding handling for dying task group leaders c03cd7738a83
("cgroup: Include dying leaders with live threads in PROCS
iterations") added an inverted cset skip condition to
css_task_iter_advance_css_set(). It should skip cset if it's
completely empty but was incorrectly testing for the inverse condition
for the dying_tasks list. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: c03cd7738a83 ("cgroup: Include dying leaders with live threads in PROCS iterations")
Reported-by: syzbot+d4bba5ccd4f9a2a68681@syzkaller.appspotmail.com
Diffstat (limited to 'kernel/cgroup')
| -rw-r--r-- | kernel/cgroup/cgroup.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 9538a12d42d6..6420ff87d72c 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4401,7 +4401,7 @@ static void css_task_iter_advance_css_set(struct css_task_iter *it) it->task_pos = NULL; return; } - } while (!css_set_populated(cset) && !list_empty(&cset->dying_tasks)); + } while (!css_set_populated(cset) && list_empty(&cset->dying_tasks)); if (!list_empty(&cset->tasks)) it->task_pos = cset->tasks.next; |