diff options
| author | Jean Delvare <khali@linux-fr.org> | 2008-09-01 17:44:05 +0200 |
|---|---|---|
| committer | Jaroslav Kysela <perex@perex.cz> | 2008-09-09 09:11:07 +0200 |
| commit | d280289e799dcdf5913e8935bffe136d7594e26d (patch) | |
| tree | e9fd22eb177d971895093583a70ef6e54db1f899 /kernel/compat.c | |
| parent | sound: remove reference to dead sound OSS vars AEDSP16_MSS and SBPRO (diff) | |
| download | linux-d280289e799dcdf5913e8935bffe136d7594e26d.tar.xz linux-d280289e799dcdf5913e8935bffe136d7594e26d.zip | |
sound: ASoC: Fix an error path in neo1973_wm8753
The error handling in neo1973_init is incorrect:
* If platform_device_add fails, we go on with the rest of the
initialization instead of bailing out. Things will break when the
module is removed (platform_device_unregister called on a device
that wasn't registered.)
* If i2c_add_driver fails, we return an error so the module will not
load, but we don't unregister neo1973_snd_device, so we are leaking
resources.
Add the missing error handling.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Tim Niemeyer <reddog@mastersword.de>
Cc: Graeme Gregory <graeme@openmoko.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Diffstat (limited to 'kernel/compat.c')
0 files changed, 0 insertions, 0 deletions