summaryrefslogtreecommitdiffstats
path: root/kernel/cpu.c
diff options
context:
space:
mode:
authorVincent Donnefort <vincent.donnefort@arm.com>2021-02-25 17:58:20 +0100
committerIngo Molnar <mingo@kernel.org>2021-03-06 12:40:22 +0100
commitb89997aa88f0b07d8a6414c908af75062103b8c9 (patch)
tree93cb8e48ededc3b24c51cab68fb7841009697a62 /kernel/cpu.c
parentsched/fair: Fix shift-out-of-bounds in load_balance() (diff)
downloadlinux-b89997aa88f0b07d8a6414c908af75062103b8c9.tar.xz
linux-b89997aa88f0b07d8a6414c908af75062103b8c9.zip
sched/pelt: Fix task util_est update filtering
Being called for each dequeue, util_est reduces the number of its updates by filtering out when the EWMA signal is different from the task util_avg by less than 1%. It is a problem for a sudden util_avg ramp-up. Due to the decay from a previous high util_avg, EWMA might now be close enough to the new util_avg. No update would then happen while it would leave ue.enqueued with an out-of-date value. Taking into consideration the two util_est members, EWMA and enqueued for the filtering, ensures, for both, an up-to-date value. This is for now an issue only for the trace probe that might return the stale value. Functional-wise, it isn't a problem, as the value is always accessed through max(enqueued, ewma). This problem has been observed using LISA's UtilConvergence:test_means on the sd845c board. No regression observed with Hackbench on sd845c and Perf-bench sched pipe on hikey/hikey960. Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Link: https://lkml.kernel.org/r/20210225165820.1377125-1-vincent.donnefort@arm.com
Diffstat (limited to 'kernel/cpu.c')
0 files changed, 0 insertions, 0 deletions