diff options
| author | Dave Chinner <dchinner@redhat.com> | 2023-03-16 01:31:03 +0100 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2023-03-19 18:02:04 +0100 |
| commit | 7ba85fba47bd89618fdb7dc322bdf823b1b56efb (patch) | |
| tree | b166f989698ce725884a16b12a34f547c4759745 /kernel/fork.c | |
| parent | pcpcntrs: fix dying cpu summation race (diff) | |
| download | linux-7ba85fba47bd89618fdb7dc322bdf823b1b56efb.tar.xz linux-7ba85fba47bd89618fdb7dc322bdf823b1b56efb.zip | |
fork: remove use of percpu_counter_sum_all
This effectively reverts the change made in commit f689054aace2
("percpu_counter: add percpu_counter_sum_all interface") as the
race condition percpu_counter_sum_all() was invented to avoid is
now handled directly in percpu_counter_sum() and nobody needs to
care about summing racing with cpu unplug anymore.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'kernel/fork.c')
| -rw-r--r-- | kernel/fork.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index f68954d05e89..bcc3085e79ef 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -755,11 +755,6 @@ static void check_mm(struct mm_struct *mm) for (i = 0; i < NR_MM_COUNTERS; i++) { long x = percpu_counter_sum(&mm->rss_stat[i]); - if (likely(!x)) - continue; - - /* Making sure this is not due to race with CPU offlining. */ - x = percpu_counter_sum_all(&mm->rss_stat[i]); if (unlikely(x)) pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%ld\n", mm, resident_page_types[i], x); |