diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2020-02-16 16:17:27 +0100 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2020-03-28 04:58:51 +0100 |
commit | a08971e9488d12a10a46eb433612229767b61fd5 (patch) | |
tree | fa60afbc9e43a5a84856f61e2b0c9813d9f4a210 /kernel/futex.c | |
parent | Linux 5.6-rc1 (diff) | |
download | linux-a08971e9488d12a10a46eb433612229767b61fd5.tar.xz linux-a08971e9488d12a10a46eb433612229767b61fd5.zip |
futex: arch_futex_atomic_op_inuser() calling conventions change
Move access_ok() in and pagefault_enable()/pagefault_disable() out.
Mechanical conversion only - some instances don't really need
a separate access_ok() at all (e.g. the ones only using
get_user()/put_user(), or architectures where access_ok()
is always true); we'll deal with that in followups.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel/futex.c')
-rw-r--r-- | kernel/futex.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/futex.c b/kernel/futex.c index 0cf84c8664f2..7fdd2c949487 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -1723,10 +1723,9 @@ static int futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr) oparg = 1 << oparg; } - if (!access_ok(uaddr, sizeof(u32))) - return -EFAULT; - + pagefault_disable(); ret = arch_futex_atomic_op_inuser(op, oparg, &oldval, uaddr); + pagefault_enable(); if (ret) return ret; |