diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2007-08-22 23:01:20 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-08-23 04:52:44 +0200 |
| commit | 8b7f07155f8ee1536da2f9590f1aa9383afefb6b (patch) | |
| tree | d4f0fcf4a96734c33ed9e0470fcb28be523070a0 /kernel/irq | |
| parent | Add blacklisting capability to serial_pci to avoid misdetection of serial ports (diff) | |
| download | linux-8b7f07155f8ee1536da2f9590f1aa9383afefb6b.tar.xz linux-8b7f07155f8ee1536da2f9590f1aa9383afefb6b.zip | |
free_irq(): fix DEBUG_SHIRQ handling
If we're going to run the handler from free_irq() then we must do it with
local irq's disabled. Otherwise lockdep complains that the handler is taking
irq-safe spinlocks in a non-irq-safe fashion.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/irq')
| -rw-r--r-- | kernel/irq/manage.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 203a518b6f14..853aefbd184b 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -462,7 +462,9 @@ void free_irq(unsigned int irq, void *dev_id) * We do this after actually deregistering it, to make sure that * a 'real' IRQ doesn't run in parallel with our fake */ + local_irq_save(flags); handler(irq, dev_id); + local_irq_restore(flags); } #endif } |