diff options
author | Tejun Heo <tj@kernel.org> | 2014-02-03 20:02:57 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-08 00:42:40 +0100 |
commit | ccf02aaf8167bb8bfb3c17c01c843d309b872671 (patch) | |
tree | 744c59c27e0883dca4da631118432a8df86ce894 /kernel/itimer.c | |
parent | kernfs: restructure removal path to fix possible premature return (diff) | |
download | linux-ccf02aaf8167bb8bfb3c17c01c843d309b872671.tar.xz linux-ccf02aaf8167bb8bfb3c17c01c843d309b872671.zip |
kernfs: invoke kernfs_unmap_bin_file() directly from kernfs_deactivate()
kernfs_unmap_bin_file() is supposed to unmap all memory mappings of
the target file before kernfs_remove() finishes; however, it currently
is being called from kernfs_addrm_finish() and has the same race
problem as the original implementation of deactivation when there are
multiple removers - only the remover which snatches the node to its
addrm_cxt->removed list is guaranteed to wait for its completion
before returning.
It can be easily fixed by moving kernfs_unmap_bin_file() invocation
from kernfs_addrm_finish() to kernfs_deactivated(). The function may
be called multiple times but that shouldn't do any harm.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/itimer.c')
0 files changed, 0 insertions, 0 deletions