diff options
| author | Christoph Hellwig <hch@lst.de> | 2021-02-02 13:13:26 +0100 |
|---|---|---|
| committer | Jessica Yu <jeyu@kernel.org> | 2021-02-08 12:22:08 +0100 |
| commit | 013c1667cf78c1d847152f7116436d82dcab3db4 (patch) | |
| tree | 14ff7b6f382399544e4dbc530dfadf9b6748e3c6 /kernel/kallsyms.c | |
| parent | module: use RCU to synchronize find_module (diff) | |
| download | linux-013c1667cf78c1d847152f7116436d82dcab3db4.tar.xz linux-013c1667cf78c1d847152f7116436d82dcab3db4.zip | |
kallsyms: refactor {,module_}kallsyms_on_each_symbol
Require an explicit call to module_kallsyms_on_each_symbol to look
for symbols in modules instead of the call from kallsyms_on_each_symbol,
and acquire module_mutex inside of module_kallsyms_on_each_symbol instead
of leaving that up to the caller. Note that this slightly changes the
behavior for the livepatch code in that the symbols from vmlinux are not
iterated anymore if objname is set, but that actually is the desired
behavior in this case.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Diffstat (limited to 'kernel/kallsyms.c')
| -rw-r--r-- | kernel/kallsyms.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index fe9de067771c..a0d3f0865916 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -177,6 +177,10 @@ unsigned long kallsyms_lookup_name(const char *name) return module_kallsyms_lookup_name(name); } +/* + * Iterate over all symbols in vmlinux. For symbols from modules use + * module_kallsyms_on_each_symbol instead. + */ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, unsigned long), void *data) @@ -192,7 +196,7 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, if (ret != 0) return ret; } - return module_kallsyms_on_each_symbol(fn, data); + return 0; } static unsigned long get_symbol_pos(unsigned long addr, |