diff options
author | Sabyrzhan Tasbolatov <snovitoll@gmail.com> | 2021-01-28 12:58:01 +0100 |
---|---|---|
committer | Casey Schaufler <casey@schaufler-ca.com> | 2021-02-03 02:14:02 +0100 |
commit | 7ef4c19d245f3dc233fd4be5acea436edd1d83d8 (patch) | |
tree | bd487df0768bc5a05b851212a44c36cde6e2c17c /kernel/kexec_internal.h | |
parent | Linux 5.11-rc6 (diff) | |
download | linux-7ef4c19d245f3dc233fd4be5acea436edd1d83d8.tar.xz linux-7ef4c19d245f3dc233fd4be5acea436edd1d83d8.zip |
smackfs: restrict bytes count in smackfs write functions
syzbot found WARNINGs in several smackfs write operations where
bytes count is passed to memdup_user_nul which exceeds
GFP MAX_ORDER. Check count size if bigger than PAGE_SIZE.
Per smackfs doc, smk_write_net4addr accepts any label or -CIPSO,
smk_write_net6addr accepts any label or -DELETE. I couldn't find
any general rule for other label lengths except SMK_LABELLEN,
SMK_LONGLABEL, SMK_CIPSOMAX which are documented.
Let's constrain, in general, smackfs label lengths for PAGE_SIZE.
Although fuzzer crashes write to smackfs/netlabel on 0x400000 length.
Here is a quick way to reproduce the WARNING:
python -c "print('A' * 0x400000)" > /sys/fs/smackfs/netlabel
Reported-by: syzbot+a71a442385a0b2815497@syzkaller.appspotmail.com
Signed-off-by: Sabyrzhan Tasbolatov <snovitoll@gmail.com>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Diffstat (limited to 'kernel/kexec_internal.h')
0 files changed, 0 insertions, 0 deletions