diff options
| author | Jens Axboe <axboe@kernel.dk> | 2021-12-02 20:43:46 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-12-03 03:39:01 +0100 |
| commit | a08ed9aae8a3d2321ef378d6581cc87a3fb75b44 (patch) | |
| tree | df0fe69900a59fa4f9e3098c19b7e82f010d3e7f /kernel/kheaders.c | |
| parent | block: get rid of useless goto and label in blk_mq_get_new_requests() (diff) | |
| download | linux-a08ed9aae8a3d2321ef378d6581cc87a3fb75b44.tar.xz linux-a08ed9aae8a3d2321ef378d6581cc87a3fb75b44.zip | |
block: fix double bio queue when merging in cached request path
When we attempt to merge off the cached request path, we return NULL
if successful. This makes the caller believe that it's should allocate
a new request, and hence we end up with the bio both merged and associated
with a new request. This, predictably, leads to all sorts of crashes.
Pass in a pointer to the bio pointer, and clear it for the merge case.
Then the caller knows that the bio is already queued, and no new requests
need to get allocated.
Fixes: 5b13bc8a3fd5 ("blk-mq: cleanup request allocation")
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'kernel/kheaders.c')
0 files changed, 0 insertions, 0 deletions