summaryrefslogtreecommitdiffstats
path: root/kernel/locking
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2016-12-05 00:24:56 +0100
committerAl Viro <viro@zeniv.linux.org.uk>2016-12-05 00:29:28 +0100
commit450630975da9e7dffe540753e169dc4da5fe7c29 (patch)
tree69e584ee757fa177d64db1c3c53d816bdab05afb /kernel/locking
parentLinux 4.9-rc7 (diff)
downloadlinux-450630975da9e7dffe540753e169dc4da5fe7c29.tar.xz
linux-450630975da9e7dffe540753e169dc4da5fe7c29.zip
don't open-code file_inode()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'kernel/locking')
-rw-r--r--kernel/locking/qspinlock_stat.h12
1 files changed, 2 insertions, 10 deletions
diff --git a/kernel/locking/qspinlock_stat.h b/kernel/locking/qspinlock_stat.h
index eb0a599fcf58..e852be4851fc 100644
--- a/kernel/locking/qspinlock_stat.h
+++ b/kernel/locking/qspinlock_stat.h
@@ -108,11 +108,7 @@ static ssize_t qstat_read(struct file *file, char __user *user_buf,
/*
* Get the counter ID stored in file->f_inode->i_private
*/
- if (!file->f_inode) {
- WARN_ON_ONCE(1);
- return -EBADF;
- }
- counter = (long)(file->f_inode->i_private);
+ counter = (long)file_inode(file)->i_private;
if (counter >= qstat_num)
return -EBADF;
@@ -177,11 +173,7 @@ static ssize_t qstat_write(struct file *file, const char __user *user_buf,
/*
* Get the counter ID stored in file->f_inode->i_private
*/
- if (!file->f_inode) {
- WARN_ON_ONCE(1);
- return -EBADF;
- }
- if ((long)(file->f_inode->i_private) != qstat_reset_cnts)
+ if ((long)file_inode(file)->i_private != qstat_reset_cnts)
return count;
for_each_possible_cpu(cpu) {