summaryrefslogtreecommitdiffstats
path: root/kernel/module.c
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2006-12-30 01:48:20 +0100
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-30 19:56:41 +0100
commita3f99f8ba8cbd2d4e231b767b3d6236a555da38c (patch)
tree9e70e751e1ec612e16ebeb7eb85a76450f59b5fe /kernel/module.c
parent[PATCH] Fix compilation of via-pmu-backlight (diff)
downloadlinux-a3f99f8ba8cbd2d4e231b767b3d6236a555da38c.tar.xz
linux-a3f99f8ba8cbd2d4e231b767b3d6236a555da38c.zip
[PATCH] module: fix mod_sysfs_setup() return value
mod_sysfs_setup() doesn't return error when kobject_add_dir() failed. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Greg KH <greg@kroah.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/module.c')
-rw-r--r--kernel/module.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/module.c b/kernel/module.c
index b565eaeff7e6..dbce132b354c 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module *mod,
goto out;
mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
- if (!mod->drivers_dir)
+ if (!mod->drivers_dir) {
+ err = -ENOMEM;
goto out_unreg;
+ }
err = module_param_sysfs_setup(mod, kparam, num_params);
if (err)