summaryrefslogtreecommitdiffstats
path: root/kernel/module.c
diff options
context:
space:
mode:
authorBrian Gerst <brgerst@gmail.com>2015-04-04 14:58:23 +0200
committerIngo Molnar <mingo@kernel.org>2015-04-06 09:06:39 +0200
commit6a3713f001b3b53587e411ab0d3036ae9b0fb93b (patch)
treeb45db33d637a9465388642e04de58daa8892cf82 /kernel/module.c
parentx86/alternatives: Fix ALTERNATIVE_2 padding generation properly (diff)
downloadlinux-6a3713f001b3b53587e411ab0d3036ae9b0fb93b.tar.xz
linux-6a3713f001b3b53587e411ab0d3036ae9b0fb93b.zip
x86/signal: Remove pax argument from restore_sigcontext
The 'pax' argument is unnecesary. Instead, store the RAX value directly in regs. This pattern goes all the way back to 2.1.106pre1, when restore_sigcontext() was changed to return an error code instead of EAX directly: https://git.kernel.org/cgit/linux/kernel/git/history/history.git/diff/arch/i386/kernel/signal.c?id=9a8f8b7ca3f319bd668298d447bdf32730e51174 In 2007 sigaltstack syscall support was added, where the return value of restore_sigcontext() was changed to carry the memory-copying failure code. But instead of putting 'ax' into regs->ax directly, it was carried in via a pointer and then returned, where the generic syscall return code copied it to regs->ax. So there was never any deeper reason for this suboptimal pattern, it was simply never noticed after being introduced. Signed-off-by: Brian Gerst <brgerst@gmail.com> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1428152303-17154-1-git-send-email-brgerst@gmail.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/module.c')
0 files changed, 0 insertions, 0 deletions