diff options
author | John Ogness <john.ogness@linutronix.de> | 2024-02-07 14:41:02 +0100 |
---|---|---|
committer | Petr Mladek <pmladek@suse.com> | 2024-02-07 17:23:19 +0100 |
commit | d988d9a9b9d180bfd5c1d353b3b176cb90d6861b (patch) | |
tree | 43bbd87a3eec9deb5e486ec315a952afe8cbbcbb /kernel/panic.c | |
parent | printk: Avoid non-panic CPUs writing to ringbuffer (diff) | |
download | linux-d988d9a9b9d180bfd5c1d353b3b176cb90d6861b.tar.xz linux-d988d9a9b9d180bfd5c1d353b3b176cb90d6861b.zip |
panic: Flush kernel log buffer at the end
If the kernel crashes in a context where printk() calls always
defer printing (such as in NMI or inside a printk_safe section)
then the final panic messages will be deferred to irq_work. But
if irq_work is not available, the messages will not get printed
unless explicitly flushed. The result is that the final
"end Kernel panic" banner does not get printed.
Add one final flush after the last printk() call to make sure
the final panic messages make it out as well.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240207134103.1357162-14-john.ogness@linutronix.de
Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'kernel/panic.c')
-rw-r--r-- | kernel/panic.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/kernel/panic.c b/kernel/panic.c index 2807639aab51..f22d8f33ea14 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -446,6 +446,14 @@ void panic(const char *fmt, ...) /* Do not scroll important messages printed above */ suppress_printk = 1; + + /* + * The final messages may not have been printed if in a context that + * defers printing (such as NMI) and irq_work is not available. + * Explicitly flush the kernel log buffer one last time. + */ + console_flush_on_panic(CONSOLE_FLUSH_PENDING); + local_irq_enable(); for (i = 0; ; i += PANIC_TIMER_STEP) { touch_softlockup_watchdog(); |