diff options
| author | Petr Mladek <pmladek@suse.com> | 2022-06-23 16:51:52 +0200 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2022-06-23 18:41:40 +0200 |
| commit | 20fb0c8272bbb102d15bdd11aa64f828619dd7cc (patch) | |
| tree | 3c805018c62d4e31aa50fbe1dd0572656aec300e /kernel/panic.c | |
| parent | printk: Wait for the global console lock when the system is going down (diff) | |
| download | linux-20fb0c8272bbb102d15bdd11aa64f828619dd7cc.tar.xz linux-20fb0c8272bbb102d15bdd11aa64f828619dd7cc.zip | |
Revert "printk: Wait for the global console lock when the system is going down"
This reverts commit b87f02307d3cfbda768520f0687c51ca77e14fc3.
The testing of 5.19 release candidates revealed missing synchronization
between early and regular console functionality.
It would be possible to start the console kthreads later as a workaround.
But it is clear that console lock serialized console drivers between
each other. It opens a big area of possible problems that were not
considered by people involved in the development and review.
printk() is crucial for debugging kernel issues and console output is
very important part of it. The number of consoles is huge and a proper
review would take some time. As a result it need to be reverted for 5.19.
Link: https://lore.kernel.org/r/YrBdjVwBOVgLfHyb@alley
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220623145157.21938-2-pmladek@suse.com
Diffstat (limited to 'kernel/panic.c')
| -rw-r--r-- | kernel/panic.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/panic.c b/kernel/panic.c index fe73d18ecdf0..6737b2332275 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -273,7 +273,6 @@ void panic(const char *fmt, ...) * unfortunately means it may not be hardened to work in a * panic situation. */ - try_block_console_kthreads(10000); smp_send_stop(); } else { /* @@ -281,7 +280,6 @@ void panic(const char *fmt, ...) * kmsg_dump, we will need architecture dependent extra * works in addition to stopping other CPUs. */ - try_block_console_kthreads(10000); crash_smp_send_stop(); } |