diff options
| author | Hugh Dickins <hughd@google.com> | 2010-05-15 04:44:10 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-15 04:45:06 +0200 |
| commit | 16a2164bb03612efe79a76c73da6da44445b9287 (patch) | |
| tree | 980cb743acfe0a295d3bc70c263abcd20fd6ba80 /kernel/profile.c | |
| parent | hughd: update email address (diff) | |
| download | linux-16a2164bb03612efe79a76c73da6da44445b9287.tar.xz linux-16a2164bb03612efe79a76c73da6da44445b9287.zip | |
profile: fix stats and data leakage
If the kernel is large or the profiling step small, /proc/profile
leaks data and readprofile shows silly stats, until readprofile -r
has reset the buffer: clear the prof_buffer when it is vmalloc()ed.
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | kernel/profile.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/profile.c b/kernel/profile.c index a55d3a367ae8..dfadc5b729f1 100644 --- a/kernel/profile.c +++ b/kernel/profile.c @@ -127,8 +127,10 @@ int __ref profile_init(void) return 0; prof_buffer = vmalloc(buffer_bytes); - if (prof_buffer) + if (prof_buffer) { + memset(prof_buffer, 0, buffer_bytes); return 0; + } free_cpumask_var(prof_cpu_mask); return -ENOMEM; |