summaryrefslogtreecommitdiffstats
path: root/kernel/rcu/rcuscale.c
diff options
context:
space:
mode:
authorUladzislau Rezki (Sony) <urezki@gmail.com>2024-11-13 12:00:09 +0100
committerFrederic Weisbecker <frederic@kernel.org>2024-11-15 22:24:41 +0100
commitc229d579d047f9c4fb4d6c37d9d04b88a398e461 (patch)
tree3aa773bf2ec9bc1f114b24c69bfeb0fd78a5ea35 /kernel/rcu/rcuscale.c
parentrcuscale: Do a proper cleanup if kfree_scale_init() fails (diff)
downloadlinux-c229d579d047f9c4fb4d6c37d9d04b88a398e461.tar.xz
linux-c229d579d047f9c4fb4d6c37d9d04b88a398e461.zip
rcuscale: Remove redundant WARN_ON_ONCE() splat
There are two places where WARN_ON_ONCE() is called two times in the error paths. One which is encapsulated into if() condition and another one, which is unnecessary, is placed in the brackets. Remove an extra WARN_ON_ONCE() splat which is in brackets. Reviewed-by: Paul E. McKenney <paulmck@kernel.org> Reviewed-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Diffstat (limited to '')
-rw-r--r--kernel/rcu/rcuscale.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index d360fa44b234..0f3059b1b80d 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -889,14 +889,12 @@ kfree_scale_init(void)
if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");
- WARN_ON_ONCE(1);
firsterr = -1;
goto unwind;
}
if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {
pr_alert("ERROR: call_rcu() CBs are being too lazy!\n");
- WARN_ON_ONCE(1);
firsterr = -1;
goto unwind;
}