summaryrefslogtreecommitdiffstats
path: root/kernel/sched.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2007-10-15 17:00:13 +0200
committerIngo Molnar <mingo@elte.hu>2007-10-15 17:00:13 +0200
commit26797a34a24cfeab9951a6f42f27432c0b2546af (patch)
tree9910b5bafd0a443e58450974c55a6106d4998106 /kernel/sched.c
parentsched: run sched_domain_debug() if CONFIG_SCHED_DEBUG=y (diff)
downloadlinux-26797a34a24cfeab9951a6f42f27432c0b2546af.tar.xz
linux-26797a34a24cfeab9951a6f42f27432c0b2546af.zip
sched: break out if printing a warning in sched_domain_debug()
checkpatch.pl and Andy Whitcroft noticed the following bug: we did not break out after printing an error. Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r--kernel/sched.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index 1a80ac1b6dab..7fefd8ab8b58 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5534,16 +5534,19 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu)
printk("\n");
printk(KERN_ERR "ERROR: domain->cpu_power not "
"set\n");
+ break;
}
if (!cpus_weight(group->cpumask)) {
printk("\n");
printk(KERN_ERR "ERROR: empty group\n");
+ break;
}
if (cpus_intersects(groupmask, group->cpumask)) {
printk("\n");
printk(KERN_ERR "ERROR: repeated CPUs\n");
+ break;
}
cpus_or(groupmask, groupmask, group->cpumask);