diff options
| author | Viresh Kumar <viresh.kumar@linaro.org> | 2013-06-11 13:02:45 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2013-06-19 12:58:47 +0200 |
| commit | 94c95ba69f31e435416988ddb223c92e5b0e9e83 (patch) | |
| tree | f200c2ee947f3df78beca4089b6c7d4d23781a8a /kernel/sched | |
| parent | sched: Fix memory leakage in build_sched_groups() (diff) | |
| download | linux-94c95ba69f31e435416988ddb223c92e5b0e9e83.tar.xz linux-94c95ba69f31e435416988ddb223c92e5b0e9e83.zip | |
sched: Remove WARN_ON(!sd) from init_sched_groups_power()
sd can't be NULL in init_sched_groups_power() and so checking it for NULL isn't
useful. In case it is required, then also we need to rearrange the code a bit as
we already accessed invalid pointer sd to get sg: sg = sd->groups.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/2bbe633cd74b431c05253a8ce61fdfd5066a531b.1370948150.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 014c97f00732..21b1403a10a2 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5400,7 +5400,7 @@ static void init_sched_groups_power(int cpu, struct sched_domain *sd) { struct sched_group *sg = sd->groups; - WARN_ON(!sd || !sg); + WARN_ON(!sg); do { sg->group_weight = cpumask_weight(sched_group_cpus(sg)); |