diff options
author | James Smart <jsmart2021@gmail.com> | 2021-04-12 03:31:14 +0200 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2021-04-13 07:39:13 +0200 |
commit | f866eb06c087125619457b53e9211a9e758f64f7 (patch) | |
tree | c6ceed50fb99d933395b9eeaa55c82617986b9ad /kernel/time/timeconv.c | |
parent | scsi: lpfc: Fix crash when a REG_RPI mailbox fails triggering a LOGO response (diff) | |
download | linux-f866eb06c087125619457b53e9211a9e758f64f7.tar.xz linux-f866eb06c087125619457b53e9211a9e758f64f7.zip |
scsi: lpfc: Fix reference counting errors in lpfc_cmpl_els_rsp()
Call traces are being seen that result from a nodelist structure ref
counting error. They are typically seen after transmission of an LS_RJT ELS
response.
Aged code in lpfc_cmpl_els_rsp() calls lpfc_nlp_not_used() which, if the
ndlp reference count is exactly 1, will decrement the reference count.
Previously lpfc_nlp_put() was within lpfc_els_free_iocb(), and the 'put'
within the free would only be invoked if cmdiocb->context1 was not NULL.
Since the nodelist structure reference count is decremented when exiting
lpfc_cmpl_els_rsp() the lpfc_nlp_not_used() calls are no longer required.
Calling them is causing the reference count issue.
Fix by removing the lpfc_nlp_not_used() calls.
Link: https://lore.kernel.org/r/20210412013127.2387-4-jsmart2021@gmail.com
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'kernel/time/timeconv.c')
0 files changed, 0 insertions, 0 deletions