summaryrefslogtreecommitdiffstats
path: root/kernel/trace/trace_events.c
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2009-08-05 20:41:04 +0200
committerIngo Molnar <mingo@elte.hu>2009-08-06 06:26:09 +0200
commitaf6af30c0fcd77e621638e53ef8b176bca8bd3b4 (patch)
treefde3faf7cc117e208dd033eee707dbd9de5f912e /kernel/trace/trace_events.c
parentperf report: Add missing command line options to man page (diff)
downloadlinux-af6af30c0fcd77e621638e53ef8b176bca8bd3b4.tar.xz
linux-af6af30c0fcd77e621638e53ef8b176bca8bd3b4.zip
ftrace: Fix perf-tracepoint OOPS
Not all tracepoints are created equal, in specific the ftrace tracepoints are created with TRACE_EVENT_FORMAT() which does not generate the needed bits to tie them into perf counters. For those events, don't create the 'id' file and fail ->profile_enable when their ID is specified through other means. Reported-by: Chris Mason <chris.mason@oracle.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <1249497664.5890.4.camel@laptop> [ v2: fix build error in the !CONFIG_EVENT_PROFILE case ] Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/trace/trace_events.c')
-rw-r--r--kernel/trace/trace_events.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 23d2972b22d6..e75276a49cf5 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -940,7 +940,7 @@ event_create_dir(struct ftrace_event_call *call, struct dentry *d_events,
entry = trace_create_file("enable", 0644, call->dir, call,
enable);
- if (call->id)
+ if (call->id && call->profile_enable)
entry = trace_create_file("id", 0444, call->dir, call,
id);