summaryrefslogtreecommitdiffstats
path: root/kernel/trace/trace_kprobe.c
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2014-10-16 21:33:27 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-11-06 01:34:36 +0100
commit2622d73e51acfe1dbeb21bf2299066bdead85163 (patch)
tree06f2fff030593a0d730b61cd78da5923baec8683 /kernel/trace/trace_kprobe.c
parentpty: Don't claim slave's ctrl_lock for master's packet mode (diff)
downloadlinux-2622d73e51acfe1dbeb21bf2299066bdead85163.tar.xz
linux-2622d73e51acfe1dbeb21bf2299066bdead85163.zip
pty: Fix packet mode setting race
Because pty_set_pktmode() does not claim the slave's ctrl_lock to clear ->ctrl_status (to avoid unnecessary lock nesting), pty_set_pktmode() may accidentally erase new ->ctrl_status updates. For example, CPU 0 | CPU 1 pty_set_pktmode() | pty_start() spin_lock(master's ctrl_lock) | tty->packet = 1 | | if (tty->link->packet) | spin_lock(slave's ctrl_lock) | tty->ctrl_status = TIOCPKT_START tty->link->ctrl_status = 0 | Ensure the clear of ->ctrl_status occurs before packet mode is set (and observable on another cpu). Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Reviewed-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/trace/trace_kprobe.c')
0 files changed, 0 insertions, 0 deletions