diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2009-07-23 05:11:03 +0200 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2009-07-23 16:07:17 +0200 |
| commit | 4c739ff043e5787d97c9691d62cabf7a29e75a9d (patch) | |
| tree | d2604b88d526a4ac4b216d5d46d2834ac8171782 /kernel/trace/trace_printk.c | |
| parent | tracing/stat: Fix seqfile memory leak (diff) | |
| download | linux-4c739ff043e5787d97c9691d62cabf7a29e75a9d.tar.xz linux-4c739ff043e5787d97c9691d62cabf7a29e75a9d.zip | |
tracing: show proper address for trace-printk format
Since the trace_printk may use pointers to the format fields
in the buffer, they are exported via debugfs/tracing/printk_formats.
This is used by utilities that read the ring buffer in binary format.
It helps the utilities map the address of the format in the binary
buffer to what the printf format looks like.
Unfortunately, the way the output code works, it exports the address
of the pointer to the format address, and not the format address
itself. This makes the file totally useless in trying to figure
out what format string a binary address belongs to.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_printk.c')
| -rw-r--r-- | kernel/trace/trace_printk.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_printk.c b/kernel/trace/trace_printk.c index 7b6278110827..687699d365ae 100644 --- a/kernel/trace/trace_printk.c +++ b/kernel/trace/trace_printk.c @@ -176,7 +176,7 @@ static int t_show(struct seq_file *m, void *v) const char *str = *fmt; int i; - seq_printf(m, "0x%lx : \"", (unsigned long)fmt); + seq_printf(m, "0x%lx : \"", *(unsigned long *)fmt); /* * Tabs and new lines need to be converted. |