diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-04-11 08:55:01 +0200 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2013-04-12 20:43:34 +0200 |
commit | 6a76f8c0ab19f215af2a3442870eeb5f0e81998d (patch) | |
tree | 551f1c13779323e06b8ef906192ba7a5d87aa7b6 /kernel/watchdog.c | |
parent | tracing: Fix double free when function profile init failed (diff) | |
download | linux-6a76f8c0ab19f215af2a3442870eeb5f0e81998d.tar.xz linux-6a76f8c0ab19f215af2a3442870eeb5f0e81998d.zip |
tracing: Fix possible NULL pointer dereferences
Currently set_ftrace_pid and set_graph_function files use seq_lseek
for their fops. However seq_open() is called only for FMODE_READ in
the fops->open() so that if an user tries to seek one of those file
when she open it for writing, it sees NULL seq_file and then panic.
It can be easily reproduced with following command:
$ cd /sys/kernel/debug/tracing
$ echo 1234 | sudo tee -a set_ftrace_pid
In this example, GNU coreutils' tee opens the file with fopen(, "a")
and then the fopen() internally calls lseek().
Link: http://lkml.kernel.org/r/1365663302-2170-1-git-send-email-namhyung@kernel.org
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: stable@vger.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/watchdog.c')
0 files changed, 0 insertions, 0 deletions